Messages in this thread | | | Date | Wed, 17 Jun 2009 18:56:58 -0700 (PDT) | Subject | Re: [PATCH 2/1 v2] Re: [BUG] fib_tries related Oops in 2.6.30 | From | David Miller <> |
| |
From: Jarek Poplawski <jarkao2@gmail.com> Date: Mon, 15 Jun 2009 18:08:01 +0200
> ipv4: Fix fib_trie rebalancing, part 2 > > My previous patch, which explicitly delays freeing of tnodes by adding > them to the list to flush them after the update is finished, isn't > strict enough. It treats exceptionally tnodes without parent, assuming > they are newly created, so "invisible" for the read side yet. > > But the top tnode doesn't have parent as well, so we have to exclude > all exceptions (at least until a better way is found). Additionally we > need to move rcu assignment of this node before flushing, so the > return type of the trie_rebalance() function is changed. > > Reported-by: Yan Zheng <zheng.yan@oracle.com> > Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Applied, thanks a lot Jarek.
| |