Messages in this thread | | | Date | Wed, 17 Jun 2009 04:35:34 -0700 (PDT) | Subject | Re: [bug] __nf_ct_refresh_acct(): WARNING: at lib/list_debug.c:30 __list_add+0x7d/0xad() | From | David Miller <> |
| |
From: Ingo Molnar <mingo@elte.hu> Date: Wed, 17 Jun 2009 13:08:03 +0200
> > * Eric Dumazet <eric.dumazet@gmail.com> wrote: > >> IPS_CONFIRMED_BIT is set under nf_conntrack_lock (in __nf_conntrack_confirm()), >> we probably want to add a synchronisation under ct->lock as well, >> or __nf_ct_refresh_acct() could set ct->timeout.expires to extra_jiffies, >> while a different cpu could confirm the conntrack. >> >> Following patch as RFC > > A quick test suggests that it seems to works here - thanks Eric!
Patrick, please take a quick look at Eric's fix. I'd like to apply it quickly if it looks good to you.
Thanks!
| |