Messages in this thread Patch in this message | | | Date | Wed, 17 Jun 2009 11:13:29 GMT | From | tip-bot for Li Zefan <> | Subject | [tip:tracing/urgent] tracing/filters: free filter_string in destroy_preds() |
| |
Commit-ID: 57be88878e7aa38750384704d811485a607bbda4 Gitweb: http://git.kernel.org/tip/57be88878e7aa38750384704d811485a607bbda4 Author: Li Zefan <lizf@cn.fujitsu.com> AuthorDate: Tue, 16 Jun 2009 16:39:12 +0800 Committer: Steven Rostedt <rostedt@goodmis.org> CommitDate: Tue, 16 Jun 2009 16:25:35 -0400
tracing/filters: free filter_string in destroy_preds()
filter->filter_string is not freed when unloading a module:
# insmod trace-events-sample.ko # echo "bar < 100" > /mnt/tracing/events/sample/foo_bar/filter # rmmod trace-events-sample.ko
[ Impact: fix memory leak when unloading module ]
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> LKML-Reference: <4A375A30.9060802@cn.fujitsu.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
--- kernel/trace/trace_events_filter.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c index b24ab0e..d9f01c1 100644 --- a/kernel/trace/trace_events_filter.c +++ b/kernel/trace/trace_events_filter.c @@ -381,6 +381,7 @@ void destroy_preds(struct ftrace_event_call *call) filter_free_pred(filter->preds[i]); } kfree(filter->preds); + kfree(filter->filter_string); kfree(filter); call->filter = NULL; }
| |