lkml.org 
[lkml]   [2009]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: [BUG] timer_migration interface accepts any number as input in 2.6.30-git9
    From
    Date
    On Wed, 2009-06-17 at 14:42 +0530, poornima nayak wrote:
    > Hi
    >
    > Timer migration interface /proc/sys/kernel/timer_migration in
    > 2.6.30-git9 accepts any numerical value as input.
    > Steps to reproduce
    > 1. echo -6666666 > /proc/sys/kernel/timer_migration
    > 2. cat /proc/sys/kernel/timer_migration
    > -6666666
    >
    > 1. echo 44444444444444444444444444444444444444444444444444444444444 > /proc/sys/kernel/timer_migration
    > 2. cat /proc/sys/kernel/timer_migration
    > -1357789412
    >
    > Expected behavior: Should 'echo: write error: Invalid argument' while
    > setting any value other then 0 & 1
    >

    Is this patch fix your problem:

    [PATCH] kernel/sysctl: fix timer migration interface

    Timer migration interface /proc/sys/kernel/timer_migration in
    2.6.30-git9 accepts any numerical value as input.
    Steps to reproduce
    1. echo -6666666 > /proc/sys/kernel/timer_migration
    2. cat /proc/sys/kernel/timer_migration
    -6666666

    1. echo 44444444444444444444444444444444444444444444444444444444444 > /proc/sys/kernel/timer_migration
    2. cat /proc/sys/kernel/timer_migration
    -1357789412

    Expected behavior: Should 'echo: write error: Invalid argument' while
    setting any value other then 0 & 1

    Reported-by: Poornima Nayak <mpnayak@linux.vnet.ibm.com>
    Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
    ---
    kernel/sysctl.c | 5 ++++-
    1 files changed, 4 insertions(+), 1 deletions(-)

    diff --git a/kernel/sysctl.c b/kernel/sysctl.c
    index ac57832..d0f65e4 100644
    --- a/kernel/sysctl.c
    +++ b/kernel/sysctl.c
    @@ -334,7 +334,10 @@ static struct ctl_table kern_table[] = {
    .data = &sysctl_timer_migration,
    .maxlen = sizeof(unsigned int),
    .mode = 0644,
    - .proc_handler = &proc_dointvec,
    + .proc_handler = &proc_dointvec_minmax,
    + .strategy = &sysctl_intvec,
    + .extra1 = &zero,
    + .extra2 = &one,
    },
    #endif
    {
    --
    1.6.0.6





    \
     
     \ /
      Last update: 2009-06-17 12:43    [W:0.021 / U:10.328 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site