Messages in this thread | | | From | Jeremy Fitzhardinge <> | Subject | [PATCH 00/16] Cleanups to io_apic.c | Date | Tue, 16 Jun 2009 13:15:39 -0700 |
| |
Hi Ingo,
Here's a series of little cleanup patches to kernel/apic/io_apic.c which I fixed as I was reviewing the code.
There are a few classes of cleanup here: - Unification of 32 and 64-bit variants, where they are functionally identical.
- Removing unnecessary #ifdef CONFIG_X86_32/64 (similar to unification, except its code which is at worst a no-op on the other platform). This cleans up the appearance of the code, and makes compile-test coverage broader. For the 82093AA workaround, the test should be more fine-grained (ie, actually look at the I/O APIC version).
- Restructure loops to use more conventional forms (lots of odd loops which can be easily represented by a plain for() loop)
- Fix some comments, delete redundant decls, etc.
Jeremy Fitzhardinge (12): x86/acpi: acpi_parse_madt_ioapic_entries: remove redundant braces x86/ioapic.c: ioapic_modify_irq is too large to inline x86/ioapic.c: unify __mask_IO_APIC_irq() x86/ioapic.c: remove #ifdef for 82093AA workaround x86/ioapic.c: remove redundant declaration of irq_pin_list x86/ioapic.c: move lost comment to what seems like appropriate place x86/ioapic.c: convert io_apic_level_ack_pending loop to normal for() loop x86/ioapic.c: simplify add_pin_to_irq_node() x86/ioapic.c: convert replace_pin_at_irq_node to conventional for() loop x86/ioapic.c: clean up replace_pin_at_irq_node logic and comments x86/ioapic.c: convert __target_IO_APIC_irq to conventional for() loop x86/ioapic.c: unify ioapic_retrigger_irq()
arch/x86/kernel/acpi/boot.c | 3 +- arch/x86/kernel/apic/io_apic.c | 144 ++++++++++++---------------------------- 2 files changed, 45 insertions(+), 102 deletions(-)
Thanks, J
| |