Messages in this thread Patch in this message | | | From | Alan Cox <> | Subject | [PATCH 1/9] tty: Fix leaks introduced by the shift to separate ldisc objects | Date | Tue, 16 Jun 2009 17:00:26 +0100 |
| |
From: Alan Cox <alan@linux.intel.com>
Gold star for the kmemleak detector.
Signed-off-by: Alan Cox <alan@linux.intel.com> ---
drivers/char/tty_ldisc.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tty_ldisc.c b/drivers/char/tty_ldisc.c index 39c8f86..94b3e06 100644 --- a/drivers/char/tty_ldisc.c +++ b/drivers/char/tty_ldisc.c @@ -148,8 +148,10 @@ static struct tty_ldisc *tty_ldisc_try_get(int disc) } } spin_unlock_irqrestore(&tty_ldisc_lock, flags); - if (err) + if (err) { + kfree(ld); return ERR_PTR(err); + } return ld; } @@ -262,7 +264,7 @@ const struct file_operations tty_ldiscs_proc_fops = { * @ld: line discipline * * Install an instance of a line discipline into a tty structure. The - * ldisc must have a reference count above zero to ensure it remains/ + * ldisc must have a reference count above zero to ensure it remains. * The tty instance refcount starts at zero. * * Locking:
| |