Messages in this thread | | | Date | Tue, 16 Jun 2009 10:00:52 +0100 | From | Alan Cox <> | Subject | Re: [bug] WARNING: at drivers/char/tty_io.c:1266 tty_open+0x1ea/0x388() |
| |
> I'm wondering, how long have these patches been in linux-next? Has > no-one reported an easy (or easier) reproducer than a plain bootup > (which really doesnt hit the tty code intentionally hard)?
Quite a while - and the open side stuff hasn't changed in the post 2.6.30 patches at all. Your box seems to show stuff up that most users just don't hit.
> You should probably also write testcases and stress-tests if you > modify code in this area.
I did - they hang the tty layers in 2.6.30 and earlier in about 60 seconds, it then corrupts the module counts and dies shortly after. I've not published them because they can obviously be seriously misused.
I don't have the luxury of building on solid foundations trying to sort the tty layer out - its been broken since 2.1.x when the lock_kernel logic stopped applying to IRQ handlers.
Alan
| |