Messages in this thread | | | Date | Tue, 16 Jun 2009 09:28:48 +0800 | From | Alek Du <> | Subject | Re: [PATCH] gpiolib: Add gpio_detect, gpio_debounce and gpio_alt_func features to GPIOLIB |
| |
On Mon, 15 Jun 2009 21:09:06 +0800 Ben Dooks <ben-linux@fluff.org> wrote:
> > > > I would expect your architecture IRQ handler to have a set_type callback for > > the GPIO lines capables of generating an interrupt. See how we have beeing > > doing it for rb532 for instance: > > http://www.linux-mips.org/git?p=linux-queue.git;a=blob;f=arch/mips/rb532/irq.c;h=f07882029a90d3d155c17b462812c2936229458c;hb=HEAD#l173 > > Yes, or if the GPIO driver is exporting interrupts, the relevant handler > for that chip should have the .set_type method defined. >
In the .set_type method, you finally will call the GPIO driver's function to set interrupt trigger mode, right? Current GPIOLIB do not provide such an interface. Current driver always exports a separate function to do that -- that's not good. My patch provide a general API to do that.
Thanks, Alek
| |