lkml.org 
[lkml]   [2009]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/3] [ARM] msm: make debugging UART (for DEBUG_LL) configurable
    On Mon 2009-06-15 11:30:11, Brian Swetland wrote:
    > On Mon, Jun 15, 2009 at 6:20 AM, Pavel Machek<pavel@ucw.cz> wrote:
    > > Hi!
    > >
    > >> Signed-off-by: Brian Swetland <swetland@google.com>
    > >> ---
    > >>  arch/arm/mach-msm/Kconfig                    |   24 ++++++++++++++++++++++++
    > >>  arch/arm/mach-msm/include/mach/debug-macro.S |   25 ++++++++++++++++++-------
    > >>  arch/arm/mach-msm/include/mach/msm_iomap.h   |   12 ++++++++++++
    > >>  arch/arm/mach-msm/include/mach/uncompress.h  |    7 +++++++
    > >>  arch/arm/mach-msm/io.c                       |    3 +++
    > >>  5 files changed, 64 insertions(+), 7 deletions(-)
    > >
    > > I'm not sure if this is appropriate for mainline at this point. It
    > > seems like few people have debug cable at this point...
    > >
    > >> +config MSM_DEBUG_UART
    > >> +     int
    > >> +     default 1 if MSM_DEBUG_UART1
    > >> +     default 2 if MSM_DEBUG_UART2
    > >> +     default 3 if MSM_DEBUG_UART3
    > >
    > > ...and those that do, have it at fixed uart, no?
    >
    > Well, I'd like to support the SoC generally, not just Dream -- it's
    > used in a bunch of different devices, and there's nothing that forces
    > you to use UART3 everywhere (I certainly have seen some 7k hardware
    > that uses UART1 as the debug serial port).

    Aha, ok, I guess that should go to the changelog. (Nice bonus would be
    if it was automatically/correctly set up when user selects machine
    type... Actually, how does that work if you support few boards with
    same kernel...?)



    Pavel
    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-06-15 20:37    [W:0.025 / U:91.280 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site