lkml.org 
[lkml]   [2009]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] WARN(): add a \n to the message printk


    On Mon, 15 Jun 2009, Arjan van de Ven wrote:
    >
    > - if (args)
    > + if (args) {
    > vprintk(args->fmt, args->args);
    > + printk("\n");
    > + }

    I really don't like this. What if the format already does have a '\n'? And
    what if some other CPU is printing at the same time?

    I'd almost be open to adding a "flags" field to vprintk, and allow setting
    things like "finish line with \n" there. Or perhaps even better, have a
    "vprintk_line()" function that does it with no dynamic flags. Maybe make
    it static, and move all these panic helper funtions into kernel/printk.c
    (since this really is a special case).

    I dunno. I'm just throwing out suggestions. I just don't think the above
    patch is very nice.

    Linus


    \
     
     \ /
      Last update: 2009-10-18 23:28    [W:0.031 / U:59.940 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site