lkml.org 
[lkml]   [2009]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] HWPOISON: define VM_FAULT_HWPOISON to 0 when feature is disabled
On Fri, Jun 12, 2009 at 05:35:01PM +0200, Ingo Molnar wrote:
>
> * Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> > On Fri, 12 Jun 2009, Ingo Molnar wrote:
> > >
> > > This seems like trying to handle a failure mode that cannot be
> > > and shouldnt be 'handled' really. If there's an 'already
> > > corrupted' page then the box should go down hard and fast, and
> > > we should not risk _even more user data corruption_ by trying to
> > > 'continue' in the hope of having hit some 'harmless' user
> > > process that can be killed ...
> >
> > No, the box should _not_ go down hard-and-fast. That's the last
> > thing we should *ever* do.
> >
> > We need to log it. Often at a user level (ie we want to make sure
> > it actually hits syslog, possibly goes out the network, maybe pops
> > up a window, whatever).
> >
> > Shutting down the machine is the last thing we ever want to do.
> >
> > The whole "let's panic" mentality is a disease.
>
> No doubt about that - and i'm removing BUG_ON()s and panic()s
> wherever i can and havent added a single new one myself in the past
> 5 years or so, its a disease.

In HA failover systems you often do want to panic ASAP (after logging
to serial cosole I guess) if anything like this happens so the system
can be rebooted with minimal chance of data corruption spreading.



\
 
 \ /
  Last update: 2009-06-15 08:57    [W:0.122 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site