Messages in this thread | | | Date | Mon, 15 Jun 2009 18:27:08 +0300 | Subject | Re: [GIT PULL v2] Early SLAB fixes for 2.6.31 | From | Pekka Enberg <> |
| |
Hi Christoph,
On Mon, Jun 15, 2009 at 6:11 PM, Pekka Enberg<penberg@cs.helsinki.fi> wrote: >> > But does this matter? When the debugging options are turned off, there >> > are no users for "real_gfp" and thus GCC optimizes everything away. For >> > debugging configs, the extra cacheline load doesn't matter, does it? >> >> It cleaner to have the fastpath as small as possible. Having unused >> variables in there is a bit confusing. > > OK, I can clean this up, no problem.
Actually, there's a slight complication here. If I push gfp mask to __might_sleep(), lockdep_trace_alloc() and so on, the mask is effective _everywhere_ even outside of slab. Yes, it makes sense if we push the masking right down to the page allocator but I wonder if that's something we want to do at this point?
Pekka
| |