Messages in this thread | | | Date | Mon, 15 Jun 2009 07:56:08 +0200 | From | Evgeni Golov <> | Subject | Re: [PATCH 2/2] use the TASK_COMM_LEN macro instead of sizeof(tsk->comm) |
| |
On Mon, Jun 15, 2009 at 12:14:10AM +0100, Alan Cox wrote: > On Sun, 14 Jun 2009 18:57:48 +0200 > Evgeni Golov <sargentd@die-welt.net> wrote: > > > sizeof(tsk->comm) == TASK_COMM_LEN, always, so why not use it? > > Because if the size ever changes the existing code will remain correct > and your changes will become a dangerous buffer overrun ?
But shouldn't TASK_COMM_LEN change then too? Just wondering, in the end it's a cosmetic cange, but looking at the code, we rely on TASK_COMM_LEN in other places often enough to break something when a task->comm is not TASK_COMM_LEM big.
Regards Evgeni
| |