[lkml]   [2009]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 21/22] HWPOISON: send uevent to report memory corruption
    On Mon, Jun 15, 2009 at 02:29:34PM +0800, Andi Kleen wrote:
    > On Mon, Jun 15, 2009 at 10:45:41AM +0800, Wu Fengguang wrote:
    > > This allows the user space to do some flexible policies.
    > > For example, it may either do emergency sync/shutdown
    > > or to schedule reboot at some convenient time, depending
    > > on the severeness of the corruption.
    > >
    > I don't think it's a good idea to export that much detailed information.
    > That would become a stable ABI, but might not be possible to keep
    > all these details stable. e.g. map count or reference count are
    > internal implementation details that shouldn't be exposed.
    > And what is an user space application to do with the inode? Run
    > find -inum?

    I had plan to export file path too, if available. But you are right,
    we should really think twice before exporting them.

    > Also we already report the event using low level logging mechanism.
    > in a relatively stable form.
    > It's also unclear to me what an application would do with that much
    > detail.
    > I would suggest to drop this part and the earlier flags move.
    > Please only bug fixes are this stage.

    OK, I'll get rid of the uevent patches numbered 16-21 in the next release.


     \ /
      Last update: 2009-06-15 12:33    [W:0.022 / U:57.016 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site