Messages in this thread | | | Date | Mon, 15 Jun 2009 12:31:48 +0900 | From | Kiyoshi Ueda <> | Subject | Re: [PATCH block#for-2.6.31] block: add request clone interface (v2) |
| |
Hi Jeff,
On 06/12/2009 11:33 PM +0900, Jeff Moyer wrote: > Jens Axboe <jens.axboe@oracle.com> writes: >> On Thu, Jun 11 2009, Jeff Moyer wrote: >>> Jens Axboe <jens.axboe@oracle.com> writes: >>> Is blk_rq_unprep_clone really the best name? >>> ^^^^^^ >> Probably not, but I'm not very good at coming up with elegant names. >> Your email should have included a new suggestion :-) > > Fair enough. ;) > >> - blk_rq_unprep_clone(struct request *clone) >> * Frees cloned bios from the clone request. > > Why not blk_rq_free_clone?
Because the 'clone' is not freed in this interface. This interface frees only bios in the 'clone'. Allocating/freeing the 'clone' are the caller's work, since only the caller knows how to allocate/free it.
'prep' after 'alloc' and 'unprep' before 'free' is symmetric and I feel a good candidate for my request-stacking driver, so I chose it.
Thanks, Kiyoshi Ueda
| |