Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 4/4] asm-generic: uaccess: fix access_ok() prototype | Date | Sun, 14 Jun 2009 22:17:50 +0200 |
| |
On Sunday 14 June 2009, Mike Frysinger wrote: > @@ -37,14 +37,14 @@ static inline void set_fs(mm_segment_t fs) > #define VERIFY_READ 0 > #define VERIFY_WRITE 1 > > -#define access_ok(type, addr, size) __access_ok((unsigned long)(addr),(size)) > +#define access_ok(type, addr, size) __access_ok((addr), (size)) > > /* > * The architecture should really override this if possible, at least
Upon actually testing this change, it turns out that this causes more trouble because of having to pass down pointers that may have 'const' or 'volatile' modifiers. I'm sure there is a way to do this correctly, but most architectures seem to cope well with 'unsigned long' here, and your patch 3/4 solves the original problem nicely.
Arnd <><
| |