lkml.org 
[lkml]   [2009]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 00/27] score arch files for linux
From
Date
Hi Arnd,

Arnd Bergmann <arnd@arndb.de> 写于 2009-06-10 02:19:06:

> On Tuesday 09 June 2009, liqin.chen@sunplusct.com wrote:
> > Hi Arnd, Andrew Morton and linus,
> >
> > According to your comment on score arch code,
> > we update score code base on asm-generic#next repository.
> > use arch microblaze and blackfin as reference.
>
> Ok, just finished looking over the patches and I am generally
> very happy about their quality, it usually takes much longer
> for a submission of this size to get into a mergeable shape.
>
> The only thing that I think needs to be fixed before a
> 2.6.31 release is my comment about unistd.h still containing
> the __ARCH_WANT_SYSCALL_* #defines. I consider that my fault
> because I did not make it clear enough what those are meant
> for in asm-generic/unistd.h.
>
> One more general thought: I noticed that you split the header
> files by alphabetical ordering. While there is no good way to
> split a set of interdependent files, a logical grouping
> (e.g. ABI, memory management, device, cpu) would be nice.
>
> Everything else I found are only polite suggestions of what
> can still be improved, not issues that I think need to
> be addressed immediately. I especially love how the work
> that Remis and I put into the generic header files starts
> paying off, because it makes reviewing an architecture so
> much simpler.
>
> Please add my 'Reviewed-by: Arnd Bergmann <arnd@arndb.de>'
> to your patches.
>

Based on your comments, I use asm-generic/current.h, hardirq.h,
unaligned.h etc instead of files under arch/include/asm folder.
It could work in score code.

Best Regards
Liqin
--


\
 
 \ /
  Last update: 2009-06-13 08:59    [W:0.074 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site