lkml.org 
[lkml]   [2009]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH 05/27] score: create head files cache.h cacheflush.h checksum.h cputime.h current.h
From
Date
Hi Arnd,

Arnd Bergmann <arnd@arndb.de> 写于 2009-06-10 01:07:16:

> On Tuesday 09 June 2009, liqin.chen@sunplusct.com wrote:
> > diff --git a/arch/score/include/asm/cacheflush.h
> > b/arch/score/include/asm/cacheflush.h
> > +extern void (*flush_cache_all)(void);
> > +extern void (*flush_cache_mm)(struct mm_struct *mm);
> > +extern void (*flush_cache_range)(struct vm_area_struct *vma,
> > + unsigned long start, unsigned long
end);
> > +extern void (*flush_cache_page)(struct vm_area_struct *vma,
> > + unsigned long page, unsigned long
pfn);
> > +extern void (*flush_cache_sigtramp)(unsigned long addr);
> > +extern void (*flush_icache_all)(void);
> > +extern void (*flush_icache_range)(unsigned long start, unsigned long
> > end);
> > +extern void (*flush_data_cache_page)(unsigned long addr);
>
> This is a somewhat unusual way to express these functions. It seems
> that you only have one implementation for each of them, so I wonder
> why you keep them as function pointers. Do you plan to add more CPUs
> in the future that do these differently?
>

S+core series have score7 core and score3 core, they use different ISA,
this patch only include score7 code. We will provide score3 code latter.

> > --- /dev/null
> > +++ b/arch/score/include/asm/current.h
> > @@ -0,0 +1,15 @@
> > +#ifndef _ASM_SCORE_CURRENT_H
> > +#define _ASM_SCORE_CURRENT_H
> > +
> > +#include <linux/thread_info.h>
> > +
> > +struct task_struct;
> > +
> > +static inline struct task_struct *get_current(void)
> > +{
> > + return current_thread_info()->task;
> > +}
> > +
> > +#define current get_current()
> > +
> > +#endif /* _ASM_SCORE_CURRENT_H */

> This is basically the asm-generic version, so you could just use that
> instead.
>

Use asm-generic/current.h instead.

Best Regards
Liqin
--
\
 
 \ /
  Last update: 2009-06-13 08:41    [W:0.142 / U:3.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site