lkml.org 
[lkml]   [2009]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[RFC][PATCH 3/10 -tip] x86: cpu_debug.c use a WARN_ONCE() instead of a pr_err()
    From
    Date

    Use a WARN_ONCE() instead of a pr_err(). Hitting this is a
    bug we want to fix.

    Also added email address.

    Reported-by: Ingo Molnar <mingo@elte.hu>
    Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
    ---
    arch/x86/kernel/cpu/cpu_debug.c | 6 +++---
    1 files changed, 3 insertions(+), 3 deletions(-)

    diff --git a/arch/x86/kernel/cpu/cpu_debug.c b/arch/x86/kernel/cpu/cpu_debug.c
    index f7b42d2..3aa3596 100644
    --- a/arch/x86/kernel/cpu/cpu_debug.c
    +++ b/arch/x86/kernel/cpu/cpu_debug.c
    @@ -644,8 +644,8 @@ static int cpu_init_cpu(void)
    pr_info("cpu%d(%d) debug files %d\n",
    cpu, nr_cpu_ids, per_cpu(cpu_priv_count, cpu));
    if (per_cpu(cpu_priv_count, cpu) > MAX_CPU_FILES) {
    - pr_err("Register files count %d exceeds limit %d\n",
    - per_cpu(cpu_priv_count, cpu), MAX_CPU_FILES);
    + WARN_ONCE(1, "debug files count %d exceeds limit %d\n",
    + per_cpu(cpu_priv_count, cpu), MAX_CPU_FILES);
    per_cpu(cpu_priv_count, cpu) = MAX_CPU_FILES;
    err = -ENFILE;
    }
    @@ -678,6 +678,6 @@ static void __exit cpu_debug_exit(void)
    module_init(cpu_debug_init);
    module_exit(cpu_debug_exit);

    -MODULE_AUTHOR("Jaswinder Singh Rajput");
    +MODULE_AUTHOR("Jaswinder Singh Rajput <jaswinder@kernel.org>");
    MODULE_DESCRIPTION("CPU Debug module");
    MODULE_LICENSE("GPL");
    --
    1.6.0.6




    \
     
     \ /
      Last update: 2009-06-13 18:45    [W:0.022 / U:30.232 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site