lkml.org 
[lkml]   [2009]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] perfcounters: Print the filename:line for annotated colored lines
    On Sat, Jun 13, 2009 at 05:25:31PM +0200, Frederic Weisbecker wrote:
    > When we have a colored line in perf annotate, ie a middle/high
    > overhead one, it's sometimes useful to get the matching line
    > and filename from the source file, especially this path prepares
    > to another subsequent one which will print a sorted summary of
    > midle/high overhead lines in the beginning of the output.
    >
    > Filename:Lines have the same color than the concerned ip lines.
    >
    > It can be slow because it relies on addr2line. We could also
    > use objdump with -l but that implies we would have to bufferize
    > objdump output and parse it to filter the relevant lines since
    > we want to print a sorted summary in the beginning.
    >
    > Changes in v2:
    > - fix addr2line on userspace binary
    > - fix string allocation size (missing ending null char room)
    > - fix overflow in symbol extra info
    >
    > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>


    Forgot to put "v2" in the [PATCH] token. It fixes what you reported
    Ingo, and also some other things.

    Thanks.



    \
     
     \ /
      Last update: 2009-06-13 17:31    [W:0.029 / U:0.740 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site