Messages in this thread |  | | Date | Fri, 12 Jun 2009 08:30:05 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH v2] slab,slub: ignore __GFP_WAIT if we're booting or suspending |
| |
On Fri, 12 Jun 2009 14:34:00 +0300 Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> +static gfp_t slab_gfp_mask __read_mostly = __GFP_BITS_MASK & ~__GFP_WAIT;
It'd be safer and saner to disable __GFP_FS and __GFP_IO as well. Having either of those flags set without __GFP_WAIT is a somewhat self-contradictory thing and there might be code under reclaim which assumes that __GFP_FS|__GFP_IO implies __GFP_WAIT.
<wonders why mempool_alloc() didn't clear __GFP_FS>
|  |