lkml.org 
[lkml]   [2009]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH] posix-cpu-timers: optimize calling thread_group_cputime()
From
Date
On Fri, 2009-06-12 at 12:39 +0200, Stanislaw Gruszka wrote:
> - times->utime = cputime_add(times->utime, t->utime);
> - times->stime = cputime_add(times->stime, t->stime);
> - times->sum_exec_runtime += t->se.sum_exec_runtime;
> + if (mask & TG_CPUCLOCK_UTIME)
> + times->utime = cputime_add(times->utime, t->utime);
> + if (mask & TG_CPUCLOCK_STIME)
> + times->stime = cputime_add(times->stime, t->stime);
> + if (mask & TG_CPUCLOCK_SCHED)
> + times->sum_exec_runtime += t->se.sum_exec_runtime;

Does adding 3 branches really make it faster? Since you're bound to want
at least one, I would expect the cacheline to be hot (assuming all three
variables live in the same cacheline -- if not, they should be!), so all
you're avoiding is the addition.



\
 
 \ /
  Last update: 2009-06-12 13:13    [W:0.049 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site