Messages in this thread | | | Date | Fri, 12 Jun 2009 11:56:33 +0200 | Subject | Re: [GIT PULL] Performance Counters for Linux | From | stephane eranian <> |
| |
Hi,
On Thu, Jun 11, 2009 at 6:03 PM, Ingo Molnar <mingo@elte.hu> wrote:
> The counter concept got objected to in past discussions on lkml, by > DaveM and by Stephane Eranian (i've Cc:-ed them) - so this code was > not eligible for linux-next testing - nevertheless we gave it good > testing on PowerPC and x86 and i've done a wide cross-build test as > well to try to make sure it breaks no other architecture.
I don't think you can quote me saying "I object to this code". I posted a detailed review of the API and implementation on X86 outlining lots of issues. Some got fixed, but many others are left unresolved at this point. And I will post some more shortly.
I don't think that because this code is coming from you, it should be allowed to short-circuit the established release process. You have to respond to questions, fix issues like everybody else and if that slows down the integration you cannot blame the reviewers for it.
| |