lkml.org 
[lkml]   [2009]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -mm resend] cpuhotplug: introduce try_get_online_cpus() take 3
    Andrew Morton wrote:
    >
    > I still think we should really avoid having to do this. trylocks are
    > nasty things.
    >
    > Looking at the above, one would think that a correct fix would be to fix
    > the bug in "thread 2": take the locks in the correct order? As
    > try_get_online_cpus() doesn't actually have any callers, it's hard to
    > take that thought any further.
    >
    >

    Sometimes, we can not reorder the locks' order.
    try_get_online_cpus() is really needless when no one uses it.

    Paul's expedited RCU V7 may need it:
    http://lkml.org/lkml/2009/5/22/332

    So this patch can be omitted when Paul does not use it.
    It's totally OK for me.

    Lai



    \
     
     \ /
      Last update: 2009-06-11 10:43    [W:0.020 / U:0.352 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site