[lkml]   [2009]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH -mm resend] cpuhotplug: introduce try_get_online_cpus() take 3
Andrew Morton wrote:
> I still think we should really avoid having to do this. trylocks are
> nasty things.
> Looking at the above, one would think that a correct fix would be to fix
> the bug in "thread 2": take the locks in the correct order? As
> try_get_online_cpus() doesn't actually have any callers, it's hard to
> take that thought any further.

Sometimes, we can not reorder the locks' order.
try_get_online_cpus() is really needless when no one uses it.

Paul's expedited RCU V7 may need it:

So this patch can be omitted when Paul does not use it.
It's totally OK for me.


 \ /
  Last update: 2009-06-11 10:43    [W:0.059 / U:14.460 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site