Messages in this thread | | | Date | Thu, 11 Jun 2009 09:01:37 +0100 | From | Andy Whitcroft <> | Subject | Re: [PATCH 1/2] lumpy reclaim: clean up and write lumpy reclaim |
| |
On Wed, Jun 10, 2009 at 10:51:40AM +0100, Mel Gorman wrote: > On Wed, Jun 10, 2009 at 02:24:43PM +0900, KAMEZAWA Hiroyuki wrote: > > I think lumpy reclaim should be updated to meet to current split-lru. > > This patch includes bugfix and cleanup. How do you think ? > > > > I think it needs to be split up into its component parts. This patch is > changing too much and it's very difficult to consider each change in > isolation.
I can only echo Mels comments here. It is very hard to review such a large patch which mostly is fixing a very small change. This code is pretty fragile and would need significant testing, I don't know if Mel is able to run the same tests we used when putting this together in the first place.
By the looks of the rest of the thread Kame-san is going to break this up so I'll wait for that.
Thanks!
-apw
| |