Messages in this thread | | | Subject | Re: [PATCH 2/2] SLUB: Disable debugging if it increases the minimum page order | From | Pekka Enberg <> | Date | Thu, 11 Jun 2009 17:00:24 +0300 |
| |
Hi Christoph,
On Thu, 2009-06-11 at 09:43 -0400, Christoph Lameter wrote: > We have had that with SLAB. NO! This leads to the situation that some > slabs have debug on and some have not. You just do not know which.
I do see your point but surely we don't want to use order 1 allocations in the fall-back case for kmalloc-4096? Couldn't we just add a printk saying that debug was disabled for the cache? After all, my patch is much better than what SLAB does.
On Thu, 2009-06-11 at 09:43 -0400, Christoph Lameter wrote: > Note that CONFIG_SLUB_DEBUG only enables the code to debug a slab. It does > not enable debugging for each slab. CONFIG_SLUB_DEBUG_ON does that.
True. Larry, do you have CONFIG_SLUB_DEBUG_ON enabled or are you passing SLUB debugging options to the kernel?
Pekka
| |