Messages in this thread | | | From | Kay Sievers <> | Date | Wed, 10 Jun 2009 16:51:19 +0200 | Subject | Re: [PATCH 1/2] driver core: introduce devtmpfs_wait_for_dev() |
| |
On Wed, Jun 10, 2009 at 16:27, <tom.leiming@gmail.com> wrote:
> This patch introduces devtmpfs_wait_for_dev(), which is based on devtmpfs > and can be used to remove polling for root device before mounting rootfs.
> + nodename = dev_path + 5;
I guess this is to strip "/dev/". Devtmpfs has no clue where it is mounted, it is just a simple superblock.
I guess, the caller would better pass a relative path to it, to keep all the implicit lookup magic with root=/dev/* in one place where the commandline parsing and mounting happens? For the same reason devtmpfs_mount() accepts a path instead of just assuming "/dev".
> + if (strncmp(dev_path, "/dev/", 5) != 0) > + return -1;
Same here.
Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |