lkml.org 
[lkml]   [2009]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/9 -v2] imx: serial: handle initialisation failure correctly
    Date
    From: Daniel Glöckner <dg@emlix.com>

    correctly de-initialise device when setting up failed,
    call to pdata->exit() was missing.

    Signed-off-by: Daniel Glöckner <dg@emlix.com>
    Signed-off-by: Oskar Schirmer <os@emlix.com>
    ---
    drivers/serial/imx.c | 7 ++++++-
    1 files changed, 6 insertions(+), 1 deletions(-)

    diff --git a/drivers/serial/imx.c b/drivers/serial/imx.c
    index 3fa07a9..60892a2 100644
    --- a/drivers/serial/imx.c
    +++ b/drivers/serial/imx.c
    @@ -1155,10 +1155,15 @@ static int serial_imx_probe(struct platform_device *pdev)
    goto clkput;
    }

    - uart_add_one_port(&imx_reg, &sport->port);
    + ret = uart_add_one_port(&imx_reg, &sport->port);
    + if (ret)
    + goto deinit;
    platform_set_drvdata(pdev, &sport->port);

    return 0;
    +deinit:
    + if (pdata->exit)
    + pdata->exit(pdev);
    clkput:
    clk_put(sport->clk);
    clk_disable(sport->clk);
    --
    1.5.3.7
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-06-10 14:13    [W:0.048 / U:33.304 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site