Messages in this thread | | | Date | Mon, 01 Jun 2009 10:45:38 +0200 | From | Takashi Iwai <> | Subject | Re: [alsa-devel] [PATCH] Support NVIDIA 8 channel HDMI audio |
| |
At Mon, 1 Jun 2009 07:07:30 +0200, Marek Vasut wrote: > > On Monday 01 of June 2009 04:51:16 Wei Ni wrote: > > Hi, Takashi > > I'm a Nvidia engineer, we wish to support 8 channel HDMI audio for > > MCP78/7A. > > > > I attached the patch file, it based on the latest sound git tree, > > please check it. > > > > Hi, > can you please run scripts/checkpatch.pl on the patches you submit? I'd help a > lot, thanks. > > btw. here's the output (shortened): > > total: 47 errors, 15 warnings, 349 lines checked > > 0001-Support-NVIDIA-8-channel-HDMI-audio.patch has style problems, please > review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS.
Yep, that'll be helpful. The changes there look almost fine after a quick glance, so please just fix cosmetic coding issues and repost.
thanks,
Takashi
| |