lkml.org 
[lkml]   [2009]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/5] TOMOYO: Clarify lock protected section.
    Tetsuo Handa wrote:
    > Li Zefan wrote:
    >> Tetsuo Handa wrote:
    >>> Enclose reader section in
    >>> /***** READER SECTION START *****/
    >>> and
    >>> /***** READER SECTION END *****/
    >>> and writer section in
    >>> /***** WRITER SECTION START *****/
    >>> and
    >>> /***** WRITER SECTION END *****/
    >>> in order to avoid oversighting lock protected section.
    >>>
    >> This makes me a bit uncomfortable..
    >>
    >> IMHO this seems ugly, useless, and even harmful. If it's helpful,
    >> we'd be doing this for the whole kernel tree, which is crazy..
    >>
    >> Or does tomoyo do this for it's special reason?
    >
    > I intended to help reviewers to visualize the range of protected section
    > at a glance. But if reviewers feel noisy, I can remove these markers.
    >

    I don't think it help review, but instead those '*'+UPPERCASE comments
    are disturbing.





    \
     
     \ /
      Last update: 2009-06-02 04:39    [W:0.042 / U:181.572 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site