lkml.org 
[lkml]   [2009]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/5] TOMOYO: Clarify lock protected section.
From
Date
Li Zefan wrote:
> Tetsuo Handa wrote:
> > Enclose reader section in
> > /***** READER SECTION START *****/
> > and
> > /***** READER SECTION END *****/
> > and writer section in
> > /***** WRITER SECTION START *****/
> > and
> > /***** WRITER SECTION END *****/
> > in order to avoid oversighting lock protected section.
> >
>
> This makes me a bit uncomfortable..
>
> IMHO this seems ugly, useless, and even harmful. If it's helpful,
> we'd be doing this for the whole kernel tree, which is crazy..
>
> Or does tomoyo do this for it's special reason?

I intended to help reviewers to visualize the range of protected section
at a glance. But if reviewers feel noisy, I can remove these markers.

Thanks.


\
 
 \ /
  Last update: 2009-06-02 04:33    [from the cache]
©2003-2011 Jasper Spaans