Messages in this thread | | | Subject | Re: [PATCH 2/5] TOMOYO: Clarify lock protected section. | From | Tetsuo Handa <> | Date | Tue, 02 Jun 2009 11:30:45 +0900 |
| |
Li Zefan wrote: > Tetsuo Handa wrote: > > Enclose reader section in > > /***** READER SECTION START *****/ > > and > > /***** READER SECTION END *****/ > > and writer section in > > /***** WRITER SECTION START *****/ > > and > > /***** WRITER SECTION END *****/ > > in order to avoid oversighting lock protected section. > > > > This makes me a bit uncomfortable.. > > IMHO this seems ugly, useless, and even harmful. If it's helpful, > we'd be doing this for the whole kernel tree, which is crazy.. > > Or does tomoyo do this for it's special reason?
I intended to help reviewers to visualize the range of protected section at a glance. But if reviewers feel noisy, I can remove these markers.
Thanks.
| |