Messages in this thread | | | Date | Mon, 01 Jun 2009 09:41:25 +0200 | From | Jiri Slaby <> | Subject | Re: [PATCH]:Return proper error value on failure of dentry_open |
| |
On 06/01/2009 08:11 AM, vibi sreenivasan wrote: > --- a/security/integrity/ima/ima_main.c > +++ b/security/integrity/ima/ima_main.c > @@ -201,10 +201,10 @@ int ima_path_check(struct path *path, int mask) > } > out: > mutex_unlock(&iint->mutex); > - if (file) > + if (IS_ERR(file)) > fput(file);
This makes no sense at all. If it is IS_ERR, i.e. some negative value, you don't want to pass it to fput. 'if (file)' was perfectly correct.
| |