Messages in this thread Patch in this message | | | From | Eric Paris <> | Subject | [PATCH 3/4] dnotify: do not bother to lock entry->lock when reading mask | Date | Mon, 01 Jun 2009 16:03:25 -0400 |
| |
entry->lock is needed to make sure entry->mask does not change while manipulating it. In dnotify_should_send_event() we don't care if we get an old or a new mask value out of this entry so there is no point it taking the lock.
Signed-off-by: Eric Paris <eparis@redhat.com> ---
fs/notify/dnotify/dnotify.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/fs/notify/dnotify/dnotify.c b/fs/notify/dnotify/dnotify.c index 5134e89..ec459b6 100644 --- a/fs/notify/dnotify/dnotify.c +++ b/fs/notify/dnotify/dnotify.c @@ -153,9 +153,8 @@ static bool dnotify_should_send_event(struct fsnotify_group *group, if (!entry) return false; - spin_lock(&entry->lock); send = (mask & entry->mask); - spin_unlock(&entry->lock); + fsnotify_put_mark(entry); /* matches fsnotify_find_mark_entry */ return send;
| |