lkml.org 
[lkml]   [2009]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[RFC PATCH 0/2] tracing/stat: stat entries self handling mode
Date
Hi everyone,

This patchset introduce a new mode in stat tracing which handles the
stat entries instead of the tracer.

It's a bit like the role of the ring buffer when used by the tracing
except that it deals with stat entries using a hashlist and it's
much less elaborate :)

I guess it could bring some possibilities to plug it in
TRACE_EVENT() or using something similar.

Also it should (I hope) reduce the workqueue tracing code and probably
other future stat tracers as well, if any.

I've tried to minimize the locking.
We have one lock on the fastpath: while a entry is updated by
the tracer. Only the entry is locked here and I fear there
are few other alternatives.

Another lock protects the free entry picking: when a stat entry
has not yet been touched, a free entry is picked up from a list
which is protected with a spinlock too. It also protects against
concurrent removals on the hash list: the entry in turn come
back to the free nodes on removal.
This one doesn't worries me much: the free entry picking happens
only once for each stat entry. And the removals are rare.

Concerning the hash list walking, it is done through rcu.

Another annoying thing, I use raw_spinlock because I'm locking
in the tracing fastpath (entry update), so in case it is used
to trace the locks once day, it's more safe against tracing
recursion.

Thanks,
Frederic.


Frederic Weisbecker (2):
tracing/stat: introduce new hashlist mode
tracing/stat: provide a sample example to use the hashlist based stat
tracing

kernel/trace/Makefile | 1 +
kernel/trace/trace_stat.c | 329 ++++++++++++++++++++++++++++++++++++++++++++-
kernel/trace/trace_stat.h | 27 ++++-
kernel/trace/trace_test.c | 108 +++++++++++++++
4 files changed, 462 insertions(+), 3 deletions(-)
create mode 100644 kernel/trace/trace_test.c



\
 
 \ /
  Last update: 2009-06-01 07:43    [W:0.040 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site