lkml.org 
[lkml]   [2009]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] tracing/mm: add page frame snapshot trace
On Sat, May 09, 2009 at 06:22:54PM +0800, Ingo Molnar wrote:
>
> * Wu Fengguang <fengguang.wu@intel.com> wrote:
>
> > > How about changing it from 'trigger' to 'dump_range':
> >
> > That's a better name!
> >
> > > echo "*" > /debug/tracing/objects/mm/pages/dump_range
> > >
> > > being a shortcut for 'dump all'?
> >
> > No I'm not complaining about -1. That's even better than "*",
> > because the latter can easily be expanded by shell ;)
> >
> > > And:
> > >
> > > echo "1000 2000" > /debug/tracing/objects/mm/pages/dump_range
> > >
> > > ?
> >
> > Now it's much more intuitive!
> >
> > > The '1000' is the offset where the dumping starts, and 2000 is the
> > > size of the dump.
> >
> > Ah the second parameter 2000 can easily be taken as "end"..
>
> Ok ... i've changed the name to dump_range and added your fix for
> mapcount as well. I pushed it all out to -tip.

Thanks.

> Would you be interested in having a look at that and tweaking the
> dump_range API to any variant of your liking, and sending a patch
> for that? Both "<start> <end>" and "<start> <size>" (or any other
> variant) would be fine IMHO.

Sure. I can even volunteer the process/file page walk works :)

> The lseek hack is nice (and we can keep that) but an explicit range
> API would be nice, we try to keep all of ftrace scriptable.

OK.

Thanks,
Fengguang


\
 
 \ /
  Last update: 2009-05-09 12:51    [W:0.245 / U:0.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site