Messages in this thread | | | Date | Sun, 10 May 2009 08:55:17 +0900 | Subject | Re: [PATCH 1/1] DMA: mark DMA_nBITS_MASK as deprecated | From | FUJITA Tomonori <> |
| |
On Fri, 8 May 2009 10:00:38 +0200 Jiri Slaby <jirislaby@gmail.com> wrote:
> Ingo Molnar <mingo@elte.hu> wrote: > > Can you see a way to emit build warnings? If yes then that might be > > a better solution instead of breaking in-the-pipeline code. > > What about this: > -- > > Mark them deprecated so that 3rd party vendors get notified about that > before their modules break by removing those macros later. > > Signed-off-by: Jiri Slaby <jirislaby@gmail.com> > --- > include/linux/dma-mapping.h | 26 ++++++++++++++------------ > 1 files changed, 14 insertions(+), 12 deletions(-)
Ah, nice magic!
Well, "warning: 'DMA_DEPRECATED' is deprecated" warning message is a bit obscure but the developers should notice that they do something wrong.
Acked-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Thanks a lot,
| |