[lkml]   [2009]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/3] block: add alt_size

    Kay Sievers wrote:
    > What does "alt_" stand for? I think that should be more descriptive in
    > an exported interface.


    > And can we please keep the "size_*" in front of the name, so that they
    > group together?

    Maybe, but size_alt? Any better ideas?

    > Also, values with magic block counts, while there is no way to get the
    > blocksize with the same interface, are pretty weird. I think the
    > current "size" attribute is just a bug.

    Logical block size is fixed at 512 bytes. Offset and size are always
    represented in multiples of 512 bytes and only get converted to
    hardware block size in the lld.

    > Not sure, how that should be solved, by adding a "blocksize" attribute
    > that is always in the same context as the current "size*" values, or
    > by just using bytes for new attributes here.
    > Almost all tools I've seen using these attributes, have hardcoded *
    > 512 in there, which may cause trouble pretty soon. And this is mostly
    > a failure of the interface and not of the users, I think.

    No, it will never break. It will always be 512. It's there to give
    nine bit shift to allow additional 9 bit of addressing without going
    to the next full blown bitwidth. It's chosen to be the lowest common
    denominator which gives enough addressing boost to hold things
    together till the next bitwidth becomes popular.

    For userlevel exporting, it might have been better to use just bytes
    there as preformance isn't really an issue, but, well, it's already
    determined, so..



     \ /
      Last update: 2009-05-09 16:07    [W:0.021 / U:7.704 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site