Messages in this thread | | | Subject | Re: [PATCH 2/2] SLUB: Use GFP_PANIC for early-boot allocations | From | Pekka Enberg <> | Date | Fri, 08 May 2009 18:45:58 +0300 |
| |
Hi Peter,
On Fri, 2009-05-08 at 11:28 -0400, Christoph Lameter wrote: > > > On Fri, 8 May 2009, Pekka Enberg wrote: > > > > > > > This patch converts SLUB early-boot code to use GFP_PANIC instead of explicit > > > > BUG_ON() calls. > > > > > > Yirks this is not only early boot code. create_unique_id may be executed > > > whenever a slab is created.
On Fri, 2009-05-08 at 18:36 +0300, Pekka Enberg wrote: > > Argh. We should do -ENOMEM there then. I'll drop that hunk.
On Fri, 2009-05-08 at 17:42 +0200, Peter Zijlstra wrote: > BUG_ON((gfp & __GFP_PANIC) && (system_state != STATE_BOOTING));
There's no technical reason not to use GFP_PANIC when system_state != STATE_BOOTING so I don't think it's needed. It's just that GFP_PANIC (and BUG_ON) is IMHO too harsh for create_unique_id().
Pekka
| |