Messages in this thread | | | Subject | Re: [RFC/PATCH v2] mm: Introduce GFP_PANIC for non-failing allocations | From | Pekka Enberg <> | Date | Fri, 08 May 2009 16:50:07 +0300 |
| |
On Fri, 2009-05-08 at 17:37 +0400, Cyrill Gorcunov wrote: > Thanks Pekka! At moment it's usefull for x86 uv_system_init (3 times) > for early boot code. Plain panic_on_null (suggested by Andrew) could > be usefull as well but would lead to additional wrapper around kmalloc > which is already inlined. Which means -- at moment we have those cases > handled by BUG_ON but having one common option would be better I guess > (ie have an ability to say page allocator that just do panic on fail). > > Anyway, if there is still objections on such an approach (even having > gpf bits saved by elegant way Pekka suggested) -- I'm fine with having > those BUG_ONs instead of short and gracious GFP_PANIC :)
There are such BUG_ONs in SLUB, for example, and probably elsewhere in early-boot code.
Pekka
| |