Messages in this thread Patches in this message | | | Date | Thu, 7 May 2009 10:08:35 +0200 | Subject | Re: [PATCH] x86 microcode: work_on_cpu and cleanup of the synchronization logic | From | Dmitry Adamushko <> |
| |
2009/5/7 Dmitry Adamushko <dmitry.adamushko@gmail.com>: > Signed-off-by: Dmitry Adamushko <dmitry.adamushko@gmail.com> > CC: Hugh Dickins <hugh@veritas.com> > CC: Rusty Russell <rusty@rustcorp.com.au> > CC: Ingo Molnar <mingo@elte.hu> > CC: Andreas Herrmann <andreas.herrmann3@amd.com> > CC: Peter Oruba <peter.oruba@amd.com> > CC: Arjan van de Ven <arjan@infradead.org> > > arch/x86/include/asm/microcode.h | 19 ++- > arch/x86/kernel/microcode_amd.c | 58 +++----- > arch/x86/kernel/microcode_core.c | 275 ++++++++++++++++++++++--------------- > arch/x86/kernel/microcode_intel.c | 92 +++++-------- > 4 files changed, 234 insertions(+), 210 deletions(-) > > (there are ~20 new comment lines)
My fault, I forgot to remove a minor debuging trick. The previous patch should be accompanied by the following.
Andreas, any chance you could give it a try with AMD setups? TIA.
(non-white-space-damaged version is enclosed)
--- arch/x86/kernel/microcode_intel-orig.c 2009-05-07 09:57:00.000000000 +0200 +++ arch/x86/kernel/microcode_intel.c 2009-05-07 09:57:47.000000000 +0200 @@ -179,7 +179,7 @@ static inline int update_match_cpu(struc static inline int update_match_revision(struct microcode_header_intel *mc_header, int rev) { - return (mc_header->rev < rev) ? 0 : 1; + return (mc_header->rev <= rev) ? 0 : 1; }
static int microcode_sanity_check(void *mc)
-- Best regards, Dmitry Adamushko --- arch/x86/kernel/microcode_intel-orig.c 2009-05-07 09:57:00.000000000 +0200 +++ arch/x86/kernel/microcode_intel.c 2009-05-07 09:57:47.000000000 +0200 @@ -179,7 +179,7 @@ static inline int update_match_cpu(struc static inline int update_match_revision(struct microcode_header_intel *mc_header, int rev) { - return (mc_header->rev < rev) ? 0 : 1; + return (mc_header->rev <= rev) ? 0 : 1; } static int microcode_sanity_check(void *mc) | |