Messages in this thread | | | From | Roland McGrath <> | Subject | Re: [FOR REVIEW, PATCH 2/2] introduce "struct wait_opts" to simplify do_wait() pathes | Date | Thu, 7 May 2009 00:49:30 -0700 (PDT) |
| |
> I must admit, I do not agree. I feel the opposite. Yes we have 2 repeated > assignment blocks, but there are not exactly equal, and imho the difference > is more visible this way.
Ok, whatever.
> That said. This is not the technical issue, I can't "prove" I am right and > of course I may be wrong. I think we should follow the "maintaner is always > right" rule ;) > > I'll send this change as another cleanup on top of the new series.
Nah. The "he who wrote the last patch is the real maintainer" rule is better. If the theoretical pitfalls I imagine ever materialize under our feet, I'll tell everybody it was your fault (git will, anyway). ;-)
Thanks, Roland
| |