lkml.org 
[lkml]   [2009]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] usb,early_printk: insert cr prior to nl as needed

* Greg KH <greg@kroah.com> wrote:

> On Wed, May 06, 2009 at 09:30:25AM +0200, Ingo Molnar wrote:
> >
> > * Jason Wessel <jason.wessel@windriver.com> wrote:
> >
> > > The rs232 drivers send a carriage return prior to a new line in the
> > > early printk code.
> > >
> > > The usb debug driver should do the same because you want to be able to
> > > use the same terminal programs and tools for analysis of early printk
> > > data.
> > >
> > > Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
> > > ---
> > > arch/x86/kernel/early_printk.c | 22 ++++++++++++++++------
> > > 1 files changed, 16 insertions(+), 6 deletions(-)
> >
> > hm, would be better to carry this in the x86 tree - where most of
> > the early-debug functionality has been authored and maintained.
> >
> > Greg, is that fine with you?
>
> Yes, but it needs a few more rounds to fix the bugs pointed out.
> So please don't take this one yet.

Sure, will wait for your Acked-by to show up in the changelog.

Ingo


\
 
 \ /
  Last update: 2009-05-07 17:07    [W:1.474 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site