lkml.org 
[lkml]   [2009]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/2] Intel-IOMMU, intr-remap: set the whole 128bits of irte when modify/free it
    Date
    Interrupt remapping table entry is 128bits. Currently, it only sets low
    64bits of irte in modify_irte and free_irte. This ignores high 64bits
    setting of irte, that means source-id setting will be ignored. This patch
    sets the whole 128bits of irte when modify/free it. Following source-id
    checking patch depends on this.

    Signed-off-by: Weidong Han <weidong.han@intel.com>
    ---
    drivers/pci/intr_remapping.c | 10 +++++++---
    1 files changed, 7 insertions(+), 3 deletions(-)

    diff --git a/drivers/pci/intr_remapping.c b/drivers/pci/intr_remapping.c
    index f5e0ea7..946e170 100644
    --- a/drivers/pci/intr_remapping.c
    +++ b/drivers/pci/intr_remapping.c
    @@ -309,7 +309,8 @@ int modify_irte(int irq, struct irte *irte_modified)
    index = irq_iommu->irte_index + irq_iommu->sub_handle;
    irte = &iommu->ir_table->base[index];

    - set_64bit((unsigned long *)irte, irte_modified->low);
    + set_64bit((unsigned long *)&irte->low, irte_modified->low);
    + set_64bit((unsigned long *)&irte->high, irte_modified->high);
    __iommu_flush_cache(iommu, irte, sizeof(*irte));

    rc = qi_flush_iec(iommu, index, 0);
    @@ -386,8 +387,11 @@ int free_irte(int irq)
    irte = &iommu->ir_table->base[index];

    if (!irq_iommu->sub_handle) {
    - for (i = 0; i < (1 << irq_iommu->irte_mask); i++)
    - set_64bit((unsigned long *)(irte + i), 0);
    + for (i = 0; i < (1 << irq_iommu->irte_mask); i++) {
    + set_64bit((unsigned long *)&irte->low, 0);
    + set_64bit((unsigned long *)&irte->high, 0);
    + irte++;
    + }
    rc = qi_flush_iec(iommu, index, irq_iommu->irte_mask);
    }

    --
    1.6.0.4


    \
     
     \ /
      Last update: 2009-05-07 08:17    [W:0.020 / U:208.452 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site