lkml.org 
[lkml]   [2009]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/11] ring-buffer: move big if statement down

* Steven Rostedt <rostedt@goodmis.org> wrote:

> This patch changes it to a goto:
>
> code;
>
> if (cross to next page)
> goto next_page;
>
> more code;
>
> return;
>
> next_page:
>
> [ lots of code]

I have pulled it, but could you please change it to a helper
function instead? There's almost never a good reason to combine
'more code' with 'lots of code' in a single function. It also
documents the unlikeliness, etc.

Ingo


\
 
 \ /
  Last update: 2009-05-06 10:27    [W:0.087 / U:4.812 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site