Messages in this thread | | | Date | Wed, 6 May 2009 10:24:47 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 10/11] ring-buffer: move big if statement down |
| |
* Steven Rostedt <rostedt@goodmis.org> wrote:
> This patch changes it to a goto: > > code; > > if (cross to next page) > goto next_page; > > more code; > > return; > > next_page: > > [ lots of code]
I have pulled it, but could you please change it to a helper function instead? There's almost never a good reason to combine 'more code' with 'lots of code' in a single function. It also documents the unlikeliness, etc.
Ingo
| |