Messages in this thread | | | Date | Thu, 7 May 2009 03:30:32 +0200 | From | Daniel Mack <> | Subject | Re: [PATCH] w1-gpio: add external pull-up enable callback |
| |
On Wed, May 06, 2009 at 11:28:18PM +0300, Ville Syrjälä wrote: > > > > This patch adds a callback function pointer to let users switch on and > > > > off the external pull-up resistor. This lets the outside world know > > > > whether the processor is currently actively driving the bus or not. > > > > > > Looks simple enough but I wonder if you could just do this from the > > > platform code. I suppose the downside would be that you would enable the > > > pullup even if w1-gpio is not loaded. > > > > That's right. Hence I put it where I believe it belongs to. > > Well, if you think you need it who am I to argue :) > > Acked-by: Ville Syrjälä <syrjala@sci.fi>
Thanks :)
Daniel
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |