lkml.org 
[lkml]   [2009]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] ptrace: do not use task_lock() for attach
* Oleg Nesterov (oleg@redhat.com) wrote:
> But this can happen without this change too?
>
> - cpu2 takes task_lock(), tracehook_tracer_task() returns NULL because
> we are not traced yet.
>
> - cpu1 does ptrace_attach() and succeds, because cpu2 didn't update sid
> yet
>
> - cpu2 continues, it doesn't check avc_has_perm() (tracer == 0) and
> updates sid.
>
> No?

Yes.

> Shouldn't selinux_setprocattr() take ->cred_exec_mutex, like we do in
> selinux_bprm_set_creds() path?

I was looking at the same, seems like it to me. James?

thanks,
-chris
>
> Oleg.


\
 
 \ /
  Last update: 2009-05-07 01:31    [W:0.054 / U:23.536 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site