lkml.org 
[lkml]   [2009]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -mmotm] mm: setup_per_zone_inactive_ratio - fix comment and make it __init
On Wed, 6 May 2009 10:19:23 +0400
Cyrill Gorcunov <gorcunov@openvz.org> wrote:

> The caller of setup_per_zone_inactive_ratio is module_init function.

__init :)

> No need to keep the callee after is completed as well.
> Also fix a comment.
>
> CC: David Rientjes <rientjes@google.com>
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>

Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
I guess the comment was a typo.

> ---
> mm/page_alloc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> Index: linux-2.6.git/mm/page_alloc.c
> =====================================================================
> --- linux-2.6.git.orig/mm/page_alloc.c
> +++ linux-2.6.git/mm/page_alloc.c
> @@ -4540,8 +4540,6 @@ void setup_per_zone_pages_min(void)
> }
>
> /**
> - * setup_per_zone_inactive_ratio - called when min_free_kbytes changes.
> - *
> * The inactive anon list should be small enough that the VM never has to
> * do too much work, but large enough that each inactive page has a chance
> * to be referenced again before it is swapped out.
> @@ -4562,7 +4560,7 @@ void setup_per_zone_pages_min(void)
> * 1TB 101 10GB
> * 10TB 320 32GB
> */
> -static void setup_per_zone_inactive_ratio(void)
> +static void __init setup_per_zone_inactive_ratio(void)
> {
> struct zone *zone;
>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>


--
Kinds Regards
Minchan Kim


\
 
 \ /
  Last update: 2009-05-06 08:55    [W:0.041 / U:6.068 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site