lkml.org 
[lkml]   [2009]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 17/58] exit_notify: kill the wrong capable(CAP_KILL) check (CVE-2009-1337)
    2.6.29-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Oleg Nesterov <oleg@redhat.com>

    CVE-2009-1337

    commit 432870dab85a2f69dc417022646cb9a70acf7f94 upstream.

    The CAP_KILL check in exit_notify() looks just wrong, kill it.

    Whatever logic we have to reset ->exit_signal, the malicious user
    can bypass it if it execs the setuid application before exiting.

    Signed-off-by: Oleg Nesterov <oleg@redhat.com>
    Acked-by: Serge Hallyn <serue@us.ibm.com>
    Acked-by: Roland McGrath <roland@redhat.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    kernel/exit.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/kernel/exit.c
    +++ b/kernel/exit.c
    @@ -950,8 +950,7 @@ static void exit_notify(struct task_stru
    */
    if (tsk->exit_signal != SIGCHLD && !task_detached(tsk) &&
    (tsk->parent_exec_id != tsk->real_parent->self_exec_id ||
    - tsk->self_exec_id != tsk->parent_exec_id) &&
    - !capable(CAP_KILL))
    + tsk->self_exec_id != tsk->parent_exec_id))
    tsk->exit_signal = SIGCHLD;

    signal = tracehook_notify_death(tsk, &cookie, group_dead);



    \
     
     \ /
      Last update: 2009-05-07 00:05    [W:0.021 / U:0.084 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site