Messages in this thread | | | From | Roland McGrath <> | Subject | Re: [RFC PATCH 3/3a] ptrace: add _ptrace_may_access() | Date | Wed, 6 May 2009 14:09:25 -0700 (PDT) |
| |
> Yeah. And at the same time we might move it out of ptrace.c and give it > a more descriptive name given that most users aren't related to ptrace > in any way. may_inspect_task maybe? I'm good at naming things..
Yes, I would like to have it outside ptrace.c (I'd forgotten about that). fs/proc/base.c is where most of the users really are, but CONFIG_PROC_FS=n makes putting it there problematical.
The name probably should stay the same unless/until we rename the LSM hooks to match. TBH, two separate hooks would make more sense to me than the PTRACE_MODE_* argument. For the hook replacing PTRACE_MODE_READ, the name may_inspect_task is apropos (not that I am attached to any given name).
Thanks, Roland
| |