lkml.org 
[lkml]   [2009]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] x86/pci: update pirq_enable_irq to setup io apic routing -v2
On Wed, 6 May 2009 14:45:58 +0200
Ingo Molnar <mingo@elte.hu> wrote:

>
> * Yinghai Lu <yinghai@kernel.org> wrote:
>
> > so we could set io apic routing only when enable device irq.
> >
> > also could make setup_IO_APIC_irqs and setup_ioapic_dest only handle
> > first ioapic...
> >
> > v2: remove one one not needed style change.
> > merge the patch only setup io_apic for acpi on in
> > setup_IO_APIC_irqs
> >
> > [ Impact: make mptable irq enable more like acpi is used, and
> > numa_irq_desc could get correct node when acpi=off ]
> >
> > Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> >
> > ---
> > arch/x86/kernel/apic/io_apic.c | 148
> > ++++++++++++++++++++---------------------
> > arch/x86/pci/irq.c | 84 ++++++++--------------- 2
> > files changed, 103 insertions(+), 129 deletions(-)
>
> Ok, i guess this makes sense with acpi-less bootup modes.
>
> There's hefty impact on io_apic.c and pci/irq.c as well. The io-apic
> code already has a fair amount of changes queued up. Jesse: do you
> have pci/irq.c changes queued up? If you agree with the patch, how
> should we handle this?

No I don't have anything recent... and since this stuff is intertwined
with the io_apic changes I'm fine with it going through you guys.

--
Jesse Barnes, Intel Open Source Technology Center


\
 
 \ /
  Last update: 2009-05-06 17:53    [W:0.033 / U:25.324 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site